#799 closed Defect (fixed)
Unused functions on PHP code
| Reported by: | Nicolas | Owned by: | davea |
|---|---|---|---|
| Priority: | Trivial | Milestone: | Undetermined |
| Component: | Web - Forums | Version: | 6.2.19 |
| Keywords: | Cc: |
Description
There is some unused code in text_transform.inc; mostly leftovers from when the forums used HTML instead of BBCode.
Attachments (2)
Change History (5)
Changed 15 years ago by
| Attachment: | remove-closeTags.diff added |
|---|
comment:1 Changed 15 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Changed 15 years ago by
| Attachment: | profile-html.diff added |
|---|
Remove sanitize_html calls from profile creation. All tags are already escaped at this point, so they are harmless.
comment:2 Changed 15 years ago by
Correction: tags aren't escaped yet. But they get escaped on display.
(that's the way it should be, the database should store it without any encoding; raw data only)
comment:3 Changed 15 years ago by
Oops... I was planning to do multiple fixes, putting them on separate patches. My bad for not expecting such a fast response!
Although on second thought, maybe profile-html.diff should be in a separate bug report... It's not unused code, it's causing bad behavior (removing stuff from profile text that it shouldn't remove); different problem...
Remove closeTags function and same-named property of output_options