Opened 17 years ago
Closed 17 years ago
#661 closed Enhancement (fixed)
New translatable strings added into to "team.inc" - tested by Rytis on PrimeGrid.
| Reported by: | Simek | Owned by: | davea |
|---|---|---|---|
| Priority: | Trivial | Milestone: | Undetermined |
| Component: | Web - Localization | Version: | |
| Keywords: | patch | Cc: |
Description
I made "team.inc" file translatable and I add those new translations strings to "en.po" file. Two patches for those files included.
Changes tested by Rytis on PrimeGrid? - thanks so much!
Attachments (2)
Change History (12)
Changed 17 years ago by
| Attachment: | team.inc.patch added |
|---|
Changed 17 years ago by
| Attachment: | en.po.patch added |
|---|
comment:1 Changed 17 years ago by
comment:2 Changed 17 years ago by
Strings should generally be at the level of sentence rather than phrase; e.g. "You may use %1limited HTML tags%2."
Nicolas, can you make these changes in team.inc?
comment:3 Changed 17 years ago by
Erm, are you sure this was tested in PrimeGrid completely? I see things that couldn't possibly work, like commas instead of concatenation operators in some places. It would make "Don't use HTML tags." go into the second column instead of below "Team name, text version".
comment:5 Changed 17 years ago by
Sure; send me the file and I'll try it on PrimeGrid.
Line 19:
row2(tra("Key words") "<br/>
should be
row2(tra("Key words")."<br/>
(notice the missing dot)
Other than that, I haven't spotted any errors.
Those replies I got for Rytis. Sorry for this mess. I'll try to fix it.
comment:6 Changed 17 years ago by
I'm working on those files now (It needs somewhat deep changes to get rid of the security bugs). You may want to wait with the translations...
comment:9 Changed 17 years ago by
For some reason the patch didn't work; see below Please post new team.inc.patch relative to trunk.
patch -p0 < temp patching file team.inc Hunk #1 FAILED at 12. Hunk #2 FAILED at 37. Hunk #3 succeeded at 60 (offset 1 line). Hunk #4 FAILED at 70. Hunk #6 FAILED at 134. Hunk #7 FAILED at 160. Hunk #8 succeeded at 204 (offset 1 line). Hunk #9 FAILED at 223. Hunk #11 succeeded at 248 (offset 1 line). Hunk #13 succeeded at 309 (offset 1 line). Hunk #15 succeeded at 364 (offset 1 line). 6 out of 15 hunks FAILED -- saving rejects to file team.inc.rej
comment:10 Changed 17 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
That is a mess to translate. How can somebody translate "without" or "You may use" if he doesn't actually look at where the strings are used?
Given this:
tra("You may use")." <a href=\"html.php\" target=\"_new\">".tra("limited HTML tags")."What if in some language the only way to say that is with "HTML tags" before "you"? Not every language has the same grammatical order. Sometimes the only way to say it is like "limited HTML tags may be used", and that's impossible with the current patch.