#597 closed Task (wontfix)
Replace our own translation system with PHP's gettext()
Reported by: | Didactylos | Owned by: | davea |
---|---|---|---|
Priority: | Minor | Milestone: | Undetermined |
Component: | Web - Project | Version: | |
Keywords: | translation PHP from-devprojects | Cc: |
Description
Replace our own translation system with PHP's gettext()
Source: DevProjects
Change History (4)
comment:1 Changed 17 years ago by
comment:2 Changed 16 years ago by
The BOINC translation system was made more up-to-date with [16190], potentially closing this ticket. Using the PHP Gettext module is probably not what we want.
comment:3 Changed 16 years ago by
Resolution: | → wontfix |
---|---|
Status: | new → closed |
Won't use gettext. See Janus's comment.
comment:4 Changed 16 years ago by
Keywords: | from-devprojects added |
---|
Note: See
TracTickets for help on using
tickets.
I have read arguments against using gettext in PHP. Biggest problem being that you need to set an environment variable to change the language. Environment variables are per-process, so gettext is not thread safe. That would make BOINC unsafe to use in a threaded webserver.
You have to be quite careful when changing the locale too. If, for example, you change the number formatting rules (decimal point and thousands separator to match user locale), you may get surprises like
UPDATE user SET total_credit=2,31;
. So you have to usenumber_format
with an explicit'.'
decimal point when constructing SQL. And wait for the next unexpected surprise.