nowork_skip causes team info to disappear from client

[Eric Myers]

When a project sets the option "nowork_skip" the scheduler does not even bother to contact the database if there is no work. As a result, the response back to the client does not indicate the team or updated stats. On the client the user's team disappears, which causes great concern and confusion. The RPC exchange needs to be adjusted so that no *change* is made to the user's team affiliation. The same may apply to other information, but the loss of team is the most visible and distressing.

[Eric Myers]

The venue is also lost, and this is also noticeable and distressing.

[Nicolas]

If I understand this correctly, the change needs to be done on the client side so that lack of team/venue tags leaves info untouched instead of clearing it out. If so, component needs to be changed (I won't change it till I get confirmation). Problem is, when you aren't attached to any team (and there is work or nowork_skip is disabled), does it get an empty tag or no tag at all?

[Eric Myers]

We seem to have another instance of this behavior. I modified the scheduler on Pirates@Home to use the "wrong version" check to only allow 6.1.14, to give the alpha testers some work involving trickles. This also causes the team to disappear. See ​http://pirates.spy-hill.net/forum_thread.php?id=926#7528

I agree with Bruce's comment completely that the primary change probably needs to be in the client, but how it's done depends on what the server sends, which may also need a coordinated change in the sever. I'm changing the Component for the ticket to "Client", but maybe not correctly.

[Eric Myers]

Ooops, I attributed Nicolas' comment to Bruce (because I saw Bruce owned the ticket). Sorry.

[Ageless]

ticket:633 is duplicate of this one.

[davea]

(In [15232]) - scheduler: there were several situations where the scheduler

would send a reply without having looked up the user and team in the DB; e.g.:

• client version# is too low
• DB is down
• host is blacklisted It would then send a full scheduler reply, including a blank team name and other missing info.

Fix this by setting reply.nucleus_only initially (this causes a minimal reply to be sent) and clearing it only if the host/user/team lookup succeeds. Fixes #417, #633 (I think)