Advanced Preferences can't handle "24:00"

[Didactylos]

Advanced Preferences can't handle the value "24:00". Neither can the simple prefs, but that doesn't matter since "Never" isn't a useful value unless you can override it with the per-day settings.

(This is almost-but-not-quite a duplicate of #300)

But this is just another bug in the advanced preferences. If it were my call, I'd bump the entire advanced preferences dialog to 6.0.

Also see #351, #352 and #173.

[Nicolas]

_{Just a sidenote: you can link to the advanced_preferences tag to see all the related tickets.}

[Ageless]

Replying to Didactylos:

Advanced Preferences can't handle the value "24:00".

If you mean in the time slots, then that's normal, isn't it? Digital clocks don't show that it is 24:00 either at midnight. It changes from 23:59 to 0:00.

So the entries go from 0:00 to 23:59.

[Didactylos]

Replying to Ageless: Almost correct. Midnight is 00:00 and 24:00 - although since clocks can't display two values at once, ​nearly all of them show 00:00. But BOINC treats 24:00 as exactly what it represents; midnight at the end of the day. As you can see, using this value is the only way to specify that BOINC never compute or connect. Here's the actual code:

    if (start==end) return false;
    if (start==0 && end==24) return false;
    if (start==24 && end==0) return true;
    if (start < end) {
        return (hour < start || hour > end);
    } else {
        return (hour >= end && hour < start);
    }

[Didactylos]

I think this is bumped to milestone:6.0 now.

[Nicolas]

Bumped.

[Didactylos]

Combined #300 with this ticket.

[davea]

(In [18866]) - manager: allow 24:00 to be used in advanced prefs dialog

(from Ian Hay; fixes #357)

[romw]

(In [18909]) - manager: allow 24:00 to be used in advanced prefs dialog

(from Ian Hay; fixes #357)

clientgui/

DlgAdvPreferences?.cpp