Opened 13 years ago

Closed 13 years ago

#1116 closed Defect (fixed)

Miscellaneous patches

Reported by: MattArsenault Owned by:
Priority: Undetermined Milestone: Undetermined
Component: Undetermined Version:
Keywords: Cc: xjakub@…

Description

1 - Updates Linux notifications to use current libnotify. 2 - Fix build problems on OS X, particularly using autotools 3 - Consistently use #if HAVE_SOMETHING for platform checks. Currently it's split between using #if HAVE_SOMETHING and #ifdef HAVE_SOMETHING or #if defined(HAVE_SOMETHING) in different places. This causes much confusion and unexpected build problems. Always defining the check to be 0/1 consistently is less prone to breaking. There's a good chance this breaks the build somewhere, but I have tested it on Linux, OS X and Windows.

4 - Fix various warnings, mostly ones about failed inlining and redundant declarations. 5 - Fix the OS X autotools build and building with recent OS X SDKs. There was some kind of perverse setting of a symbol that is defined by the configuration headers which was breaking everything.

6 - Remove unused functions. I discovered after fixing some of the old OS X API usage that the functions using them aren't actually used (along with a few random others) and it was a waste of time fixing them.

Attachments (6)

Change History (8)

Changed 13 years ago by MattArsenault

Changed 13 years ago by MattArsenault

comment:1 Changed 13 years ago by mjakubicek

Cc: xjakub@… added

Matt,

I've filed your issue nr. 1 as #1131 with some more details and links (a would suggest you do the same with most of the other issues; believe me the developer will be much happier with 1 ticket being 1 issue, not 6 from which most are totally unrelated to each other)

comment:2 Changed 13 years ago by MattArsenault

Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.