Custom Query (981 matches)

basically all versions up to 6.12.18

Hello, I am attaching one of the patches by the Debian/Ubuntu? folks that seems directly applicable. You had kindly accepted some later patches to other graphics before.

Cheers,

Steffen

1 - Updates Linux notifications to use current libnotify. 2 - Fix build problems on OS X, particularly using autotools 3 - Consistently use #if HAVE_SOMETHING for platform checks. Currently it's split between using #if HAVE_SOMETHING and #ifdef HAVE_SOMETHING or #if defined(HAVE_SOMETHING) in different places. This causes much confusion and unexpected build problems. Always defining the check to be 0/1 consistently is less prone to breaking. There's a good chance this breaks the build somewhere, but I have tested it on Linux, OS X and Windows.

4 - Fix various warnings, mostly ones about failed inlining and redundant declarations. 5 - Fix the OS X autotools build and building with recent OS X SDKs. There was some kind of perverse setting of a symbol that is defined by the configuration headers which was breaking everything.

6 - Remove unused functions. I discovered after fixing some of the old OS X API usage that the functions using them aren't actually used (along with a few random others) and it was a waste of time fixing them.

Hello,

On the file make_app_icon_h.cpp, we have this :

inFile = fopen(argv[1], "rb"); if (inFile == NULL) {

printf ("Couldn't open input file %s\n", argv[1]); return 0;

}

outFile = fopen(argv[2], "w"); if (inFile == NULL) {

printf ("Couldn't create output file %s\n", argv[2]); fclose(inFile); return 0;

}

Obviously, the second if should be : "if (outFile == NULL) {"

Julien