Opened 14 years ago
Closed 13 years ago
#1051 closed Enhancement (fixed)
[patch] some const* char warning to eliminate
| Reported by: | steffen_moeller | Owned by: | |
|---|---|---|---|
| Priority: | Trivial | Milestone: | 7.0 |
| Component: | Undetermined | Version: | 6.12.16 |
| Keywords: | Cc: |
Description
basically all versions up to 6.12.18
Hello, I am attaching one of the patches by the Debian/Ubuntu? folks that seems directly applicable. You had kindly accepted some later patches to other graphics before.
Cheers,
Steffen
Attachments (3)
Change History (6)
Changed 14 years ago by
| Attachment: | FlatBookStaticChar.patch added |
|---|
comment:1 Changed 14 years ago by
| Milestone: | Undetermined → 6.12 |
|---|---|
| Priority: | Undetermined → Trivial |
| Type: | Defect → Enhancement |
comment:2 Changed 14 years ago by
In run_program of lib/util.(cpp|h), the execution under linux is performed with the argv directly passed on via execv. That is expecting a "char *const argv[]" argument, which is very different from the "const char* const argv[]" that one would be expecting. While this grants execv some freedom for in situ modifications of that string passed as an argument, this is effectively just some historical compatibility with plain C (from http://stackoverflow.com/questions/190184/execv-and-const-ness). The attached patch fixes the usual const char* issue in the calling function of the BOINC manager.
Should you be looking this up, please also note that the Windows version will not test for the maximal path length to be exceeded in their strcat in util.cpp.
Changed 14 years ago by
| Attachment: | advanced_link_image_const.patch added |
|---|
Yet another XPM missing the "const"
comment:3 Changed 13 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
file from debian/patches .. adding "const" to xpm in .h file