Opened 15 years ago
Closed 14 years ago
#975 closed Defect (fixed)
[PATCH] generate_svn_version.sh fails on non-English systems
Reported by: | Nicolas | Owned by: | davea |
---|---|---|---|
Priority: | Minor | Milestone: | Undetermined |
Component: | Client - Build | Version: | |
Keywords: | patch | Cc: |
Description
On my computer, generate_svn_version.sh creates a svn_version.h file containing:
#define SVN_VERSION "Repository: http://boinc.berkeley.edu/svn/trunk/boinc Revision: del"
"del"? You can probably figure out why:
~/src/boinc$ svn info Ruta: . URL: http://boinc.berkeley.edu/svn/trunk/boinc Raíz del repositorio: http://boinc.berkeley.edu/svn UUID del repositorio: 677681c0-c3c0-48b4-bd46-92119ef6d97a Revisión: 20177 Tipo de nodo: directorio Agendado: normal Autor del último cambio: romw Revisión del último cambio: 20176 Fecha de último cambio: 2010-01-15 15:52:58 -0300 (vie 15 de ene de 2010)
The script is searching for ^Rev
, and "Revisión del último cambio
" matches that.
The solution is to run it under the C locale:
-
generate_svn_version.sh
16 16 fi 17 17 18 18 if [ "x$CMD" != "x" ]; then 19 $CMD | awk '/^URL/ { url = $2; }; \19 LANG=C $CMD | awk '/^URL/ { url = $2; }; \ 20 20 /^Rev/ { rev = $2; }; \ 21 21 END { print "#define SVN_VERSION \"Repository: " url \ 22 22 " Revision: " rev "\""; };' \
Change History (4)
comment:1 Changed 14 years ago by
Component: | Undetermined → Client - Build |
---|---|
Owner: | set to romw |
comment:2 Changed 14 years ago by
Summary: | generate_svn_version.sh fails on non-English systems → [PATCH] generate_svn_version.sh fails on non-English systems |
---|
comment:3 Changed 14 years ago by
Owner: | changed from romw to davea |
---|
comment:4 Changed 14 years ago by
Resolution: | → fixed |
---|---|
Status: | new → closed |
Note: See
TracTickets for help on using
tickets.
David?