Opened 15 years ago

Closed 14 years ago

#921 closed Defect (fixed)

[PATCH] alloc check for buf==NULL in util.cpp

Reported by: Joses Owned by: davea
Priority: Undetermined Milestone: Undetermined
Component: BOINC - API Version: 6.11.7
Keywords: patch memoryleak Cc:

Description

Quick fix for an error check that got missed.

Attachments (1)

util.cpp.diff​ (346 bytes) - added by Joses 15 years ago.
agains svn of june17,2009, lib/util.cpp

Download all attachments as: .zip

Change History (6)

comment:1 Changed 15 years ago by Nicolas

You're leaking the file handle if you return there.

comment:2 Changed 15 years ago by Joses

Thanks for checking. I still don't have the proper resources (or time) to compile BOINC properly so these "fixes" are going to be rather minor in size (basically see errors but untested). Hope you don't mind...

Thanks for the checkup and hope it is properly correct now. :-)

Changed 15 years ago by Joses

Attachment: util.cpp.diff​ added

agains svn of june17,2009, lib/util.cpp

comment:3 Changed 15 years ago by elfring

This issue fits also to the general topic of completion for exception handling.

comment:4 Changed 14 years ago by Christian Beer

Component: Undetermined → BOINC - API
Keywords: patch memoryleak added
Owner: set to davea
Summary: alloc check for buf==NULL in util.cpp → [PATCH] alloc check for buf==NULL in util.cpp
Version: 6.6.31 → 6.11.7

This check is still absend in trunk.

comment:5 Changed 14 years ago by davea

Resolution: → fixed
Status: new → closed

(In [22345]) - lib: check for malloc() NULL return; fixes #921

Note: See TracTickets for help on using tickets.