Linux manager doesn't start the client

[Nicolas]

As reported on boinc_alpha: the BOINC Manager is not auto-starting the core client.

Manager still fails to start the client.

This got broken somewhere before the 6.2 release and then fixed. It was broken again in the last alpha release and is still broken.

The cause:

If g_use_sandbox is not set, the manager adds --insecure to the client command line. This is done even if SANDBOX wasn't defined at compile time. The client then promptly quits saying --insecure is not a valid option. It only recognizes the option if SANDBOX was defined at compile time.

Under OS X, the manager adding --insecure is wrapped in #ifdef SANDBOX; but not on Linux.

The fix should come from both sides. The manager shouldn't add that switch if SANDBOX was disabled, but the client shouldn't quit if the switch is passed. If someone says he wants the client --insecure, and the client doesn't even have security compiled in, the client quietly ignoring the option would get the correct behavior: no security.

[Nicolas]

patch

[davea]

(In [16328]) - client: accept --insecure flag even if not compiled with -DSANDBOX

• manager: pass --insecure flab only if compiled with -DSANDBOX

(from Nicolas; fixes #762)