Opened 16 years ago

Closed 16 years ago

Last modified 16 years ago

#722 closed Defect (fixed)

remove white space from Managers locale filenames

Reported by: mjakubicek Owned by: romw
Priority: Trivial Milestone: 6.4
Component: Manager - Localization Version: 6.4.5
Keywords: Cc: mjakubicek

Description

Currently BOINC locales are called "BOINC Manager.mo". In Fedora I deploy the Manager with the attached one-line-patch which changes this to "BOINC-Manager.mo" -- for at least two reasons:

1) I can use the rpm's find_lang macro for collecting all locales automatically. This was the main reason for me.

2) Having spaces in filenames is -- in my point of view -- just plain wrong.

I know this is a very minor problem, but if you agree with the proposed change I'd be glad to see the attached patch merged upstream.

Attachments (1)

boinc-locales.patch (424 bytes) - added by mjakubicek 16 years ago.
Proposed patch

Download all attachments as: .zip

Change History (8)

Changed 16 years ago by mjakubicek

Attachment: boinc-locales.patch added

Proposed patch

comment:1 Changed 16 years ago by fthomas

These files were already renamed in r15299.

comment:2 Changed 16 years ago by mjakubicek

That's nice, but why hasn't been this change included into BOINC 6.2 branch?

comment:3 Changed 16 years ago by Nicolas

Because between the mess, the developers easily forget which changes were merged and which not.

comment:4 Changed 16 years ago by mjakubicek

Summary: RFC: remove white space from Managers locale filenamesremove white space from Managers locale filenames
Type: EnhancementDefect
Version: 6.4.5

Fine, this is still not even in BOINC 6.4.5:(

Please, please...merge it, thanks.

comment:5 Changed 16 years ago by Nicolas

Milestone: Undetermined6.4

Fixed in 6.6 branch in [16757].

I still think it should be fixed in 6.4 branch for a new 6.4.6 version (with other fixes too, of course; a whole new version just for locale renames would be overkill), as it makes the life of packagers easier.

comment:6 Changed 16 years ago by Nicolas

Resolution: fixed
Status: newclosed

comment:7 Changed 16 years ago by mjakubicek

Cc: mjakubicek added
Note: See TracTickets for help on using tickets.