Opened 16 years ago

Closed 14 years ago

#695 closed Defect (fixed)

Malformed HTML Attribute in Web Buttons

Reported by: AlphaLaser Owned by: davea
Priority: Minor Milestone: Undetermined
Component: Web - Project Version:
Keywords: malformed html Cc:

Description (last modified by Nicolas)

The HTML attributes for the <noscript> fallback in the web button code are malformed. They should be surrounded by double quotes so that attribute values containing spaces can be properly parsed.

in html/inc/util.inc, line 674: 

<a href=$url title=$title>$text</a>

should be: 

<a href=\"$url\" title=\"$title\">$text</a>

Change History (4)

comment:1 Changed 16 years ago by AlphaLaser

Make that line 674

comment:2 Changed 16 years ago by Nicolas

Description: modified (diff)

done :)

comment:3 Changed 16 years ago by jbk

Fixed in revision 16047.

We no longer use javascript or noscript fallback to generate the buttons but simply use CSS to style the link to look like a button.

comment:4 Changed 14 years ago by Christian Beer

Resolution: → fixed
Status: new → closed
Note: See TracTickets for help on using tickets.