Result status "computation error" changes to status "complete" upon reboot/restart

[Dagorath]

This error was reported in this thread on BOINC dev forums.

If user reboots or restarts BOINC when the manager has tasks with status "computation error" in the task list, the status in the task list gets changed to just "complete" on reboot/restart. It would be much more user friendly if, after reboot/restart, the status would still somehow indicate an error occurred. Perhaps it could say something like "complete but with computation error"?

[Richard Haselgrove]

I believe the same issue could also give rise to a discrepancy in the web site report for the WU.

Sometimes you see

Outcome        Client state
Client error   Compute error

and sometimes it's

Outcome        Client state
Client error   Done

It's probably caused by the same thing, and it would be good to check for web reporting at the same time as testing the Manager fix.

[Nicolas]

The state is saved incorrectly to client_state.xml. This is only noticed on a restart, because the client usually doesn't re-read the file, just keeps all state in memory.

Since the problem is state saving, it's not surprising it affects everything (reporting, manager, etc).

[davea]

(In [15231]) - client: when parsing state file, don't change result states

unless there's an inconsistency Fixes #621

[romw]

(In [15237]) - client: when parsing state file, don't change result states

unless there's an inconsistency Fixes #621

client/

client_types.C