Opened 16 years ago

Closed 16 years ago

Last modified 15 years ago

#557 closed Defect (fixed)

Hightlighting in Forum Search Results applied to HTML tags.

Reported by: Richard Haselgrove Owned by: davea
Priority: Minor Milestone: Undetermined
Component: Web - Forums Version:
Keywords: search highlight Cc:

Description

The Funky Search Result Formatting described in changeset:14267 ("For posts, show complete post, with search terms highlighted") goes too far - highlighting is applied to search terms found inside the HTML tags generated by BOINC while rendering the page.

Examples are in Bug in Forum Advanced Search.

Attachments (1)

text_transform.diff​ (1.0 KB) - added by AlphaLaser 16 years ago.
proposed fix

Download all attachments as: .zip

Change History (4)

comment:1 Changed 16 years ago by Nicolas

Keywords: search highlight added; Advanced Search Highlight removed

comment:2 Changed 16 years ago by Nicolas

A creative and motivated hacker might find a way to cause XSS with this bug.

Changed 16 years ago by AlphaLaser

Attachment: text_transform.diff​ added

proposed fix

comment:3 Changed 16 years ago by jbk

Resolution: → fixed
Status: new → closed

(In [16193]) Fixed #557 - Hightlighting in Forum Search Results applied to HTML tags. Highlighting is now done before parsing other special code.

Note: See TracTickets for help on using tickets.