Opened 10 years ago
Closed 10 years ago
#1332 closed Defect (fixed)
app version column in ops section (result table view) shows 0.00
| Reported by: | Christian Beer | Owned by: | davea |
|---|---|---|---|
| Priority: | Minor | Milestone: | Undetermined |
| Component: | Web - Project | Version: | |
| Keywords: | Cc: | Christian Beer |
Description
The app version column in the result table view of the ops section is showing 0.00 as version number (low and high detail) for in progress results although the app version id is correct.
Attachments (1)
Change History (8)
comment:1 Changed 10 years ago by
| Owner: | changed from Christian Beer to davea |
|---|
Changed 10 years ago by
| Attachment: | app_version_num_fix.diff added |
|---|
comment:2 Changed 10 years ago by
| Cc: | Christian Beer added |
|---|
comment:3 Changed 10 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Fixed. My goals with the ops/ code are:
- remove it when possible; e.g. use equivalent functions from non-ops code (like I did here, using app_version_string().
- prepare for using mysqli, possibly by using the new DB layer
comment:4 Changed 10 years ago by
| Resolution: | fixed |
|---|---|
| Status: | closed → reopened |
Text is now working but the link isn't. $result->app_version_num is 0 and thus the lookup in the app version table is empty.
comment:5 Changed 10 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | reopened → closed |
comment:6 Changed 10 years ago by
| Resolution: | fixed |
|---|---|
| Status: | closed → reopened |
I'm sorry to reopen this again but I can't find your fix in current master.
comment:7 Changed 10 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | reopened → closed |
Note: See
TracTickets for help on using
tickets.
It turns out app_version_num in results table is deprecated. I found a quick fix that doesn't break compatibility but there are better ways to improve this and show more relevant information using app_version_id. One can show the actual used platform instead.
Perhaps this is open for discussion on a redesign of the ops section. A lot of this stuff is still not adapted to the new DB layer.