Opened 11 years ago

Last modified 11 years ago

#1225 new Enhancement

[PATCH 1-2] client/ASYNC_VERIFY::verify_chunk improvements

Reported by: rctay Owned by: davea
Priority: Undetermined Milestone: Undetermined
Component: Client - Build Version:
Keywords: Cc:

Description

The attached patches are git-am-friendly and were made on top of boinc trunk.

Change History (4)

Changed 11 years ago by rctay

Attachment: 0001-client-ASYNC_VERIFY-verify_chunk-delay-casting-of-si.patch​ added

comment:1 Changed 11 years ago by rctay 

[PATCH 1/2] client/ASYNC_VERIFY::verify_chunk: delay casting of size_t to int

We only need ints when calling md5_append(), so do the casting at
call-time. This reduces the number of casts needed, as well as silences
a compiler warning on VS 2005.

We need not worry about integer overflows, as md5_append checks if the
int argument is negative.

[PATCH 2/2] client/ASYNC_VERIFY::verify_chunk: check ferror() after a fread()/fwrite()

comment:2 Changed 11 years ago by romw

Owner: changed from romw to davea

Changed 11 years ago by rctay

Attachment: 0002-client-ASYNC_VERIFY-verify_chunk-check-ferror-after-.patch​ added
Note: See TracTickets for help on using tickets.