Cppcheck leaks reported

[serval2412]

Hello,

I attached leaks (resource and memory leaks reported by cppcheck) and proposed a patch to revienw for all of them.

Julien

[serval2412]

leaks reported by cppcheck

[serval2412]

proposed patch to fix these leaks

[Nicolas]

I'm quite sure that your fix to make_app_icon_h.cpp is not correct. The bug is in the condition:

api/make_app_icon_h.cpp

@@ -40 +40 @@
     
     outFile = fopen(argv[2], "w");
-    if (inFile == NULL) {
+    if (outFile == NULL) {
         printf ("Couldn't create output file %s\n", argv[2]);
         fclose(inFile);
         return 0;

[davea]

(In [25750]) - fixes of various (non-critical) fd and memory leaks.

Fixes #1188. From Julien.

• fix bugs in setting scheduler output buffer size
• code formatting

[serval2412]

My patch contained this :

--- api/make_app_icon_h.cpp (révision 25749) +++ api/make_app_icon_h.cpp (copie de travail) @@ -41,7 +41,7 @@

outFile = fopen(argv[2], "w"); if (inFile == NULL) {

printf ("Couldn't create output file %s\n", argv[2]);

• fclose(inFile);

+ fclose(outFile);

return 0;

}

But you're right it should be outFile == NULL instead of inFile == NULL

BTW, sorry again for the ticket 1189 which is just a dup.

[serval2412]

About "outFile", I had mentionned this in Ticket #1127

[davea@…]

commit 6c966b10c5013d3aa83f1272130d734a21728f5d Author: davea <davea@677681c0-c3c0-48b4-bd46-92119ef6d97a> Date: Sun Jun 10 05:38:34 2012 +0000

• fixes of various (non-critical) fd and memory leaks.

Fixes #1188. From Julien.

• fix bugs in setting scheduler output buffer size
• code formatting

git-svn-id: http://boinc.berkeley.edu/svn/trunk/boinc@25750 677681c0-c3c0-48b4-bd46-92119ef6d97a