Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#1180 closed Defect (fixed)

sci-misc/boinc - no menu buttons in boincmgr with x11-libs/wxGTK-2.8.12.0

Reported by: toralf Owned by: romw
Priority: Critical Milestone: Undetermined
Component: Manager Version: 7.0.26
Keywords: Cc:

Description

The origin is here : https://bugs.gentoo.org/show_bug.cgi?id=379979 . It worked flawlessly with x11-libs/wxGTK-2.8.11.0

The version is 6.12.42 - but current subversion trunk show same behavior.

Change History (14)

comment:1 Changed 12 years ago by toralf

comment:2 Changed 12 years ago by Trog Dog

workaround is to resize the BM window, if this helps - workaround shamelessly stolen from redhat bugzilla

comment:3 Changed 12 years ago by toralf

yes - confirmed, that this works.

comment:4 in reply to:  3 Changed 12 years ago by Trog Dog

Replying to toralf:

yes - confirmed, that this works.

Recompiling against 2.8.11.0 works (will post on gentoo bugzilla change to make to ebuild). For the BOINC devs - something changes between wxwidgets 2.8.11 and 2.8.12 that brings about these missing menus.

comment:5 Changed 12 years ago by Ageless

Component: UndeterminedManager
Owner: set to romw
Priority: UndeterminedCritical

comment:6 Changed 12 years ago by Trog Dog

From my inbox from user Huib

Hi Mister Dog,
 
Adding a SendSizeEvent(); after installing the menubar (CAdvancedFrame::CreateMenu) seems to “fix” the problem with the disappearing menubar.
 
Groetjes,
 Huibert.

comment:7 Changed 12 years ago by Trog Dog

Based on release 2.0.27
 

Index: clientgui/AdvancedFrame.cpp
 ===================================================================
 --- clientgui/AdvancedFrame.cpp (revision 25677)
 +++ clientgui/AdvancedFrame.cpp (working copy)
 @@ -701,6 +701,10 @@

 wxMenuBar* m_pOldMenubar = GetMenuBar();
 SetMenuBar(m_pMenubar);
 +#ifdef __WXGTK__
 + /* Force WX to recalculate the size of the (new) menu bar */
 + SendSizeEvent();
 +#endif
 #ifdef __WXMAC__
 m_pMenubar->MacInstallMenuBar();
 MacLocalizeBOINCMenu();

 
Groetjes,
 Huibert

Patch supplied by Huibert (Huib on the boinc forums)

comment:8 Changed 12 years ago by Trog Dog

Version: 6.12.347.0.26

Actually still current with 7.0.28

Last edited 12 years ago by Trog Dog (previous) (diff)

comment:9 Changed 12 years ago by Trog Dog

Applied patch and tested on 5 gentoo boxes (compiled 7.0.28) and it addresses the problem.

comment:10 Changed 12 years ago by romw

Resolution: fixed
Status: newclosed

(In [25702]) - MGR: Fix menu redraw issue under Ubuntu's new interface.

fixes #1180 (From Huibert)

clientgui/

AdvancedFrame?.cpp

comment:11 Changed 12 years ago by toralf

The comment in the fix indicates it is Ubuntu specific - but it is an issue under Gentoo too.

comment:12 Changed 12 years ago by toralf

seems not fixed under an almost stable Gentoo - I still have to apply the patch against 7.0.29

comment:13 Changed 12 years ago by romw

(In [25812]) - MGR: Fix menu redraw issue under Ubuntu's new interface.

fixes #1180 (From Huibert)

clientgui/

AdvancedFrame?.cpp

comment:14 Changed 12 years ago by toralf

The issue is still in 7.0.29 here at as table Gentoo Linux - therefore I apply always this patch : tfoerste@n22 /usr/local/portage/sci-misc $ cat boinc/files/wxwidgets-2.8.0.12-menufix.patch --- clientgui/AdvancedFrame.cpp_orig 2012-05-20 00:01:49.441702516 +0200 +++ clientgui/AdvancedFrame.cpp 2012-05-20 00:03:00.136490955 +0200 @@ -701,6 +701,10 @@

wxMenuBar* m_pOldMenubar = GetMenuBar?(); SetMenuBar?(m_pMenubar);

+#ifdef WXGTK +/* Force WX to recalculate the size of the (new) menu bar */ + SendSizeEvent?(); +#endif

#ifdef WXMAC

m_pMenubar->MacInstallMenuBar?(); MacLocalizeBOINCMenu();

Note: See TracTickets for help on using tickets.