Transitioner does not generate second result if the first one is marked invalid

[TJM]

I believe that there might be a bug in transitioner, for workunits with quorum 1 marked by validator as invalid (result: server_state 5, outcome 1, client_state 5, validate_state invalid; workunit: canonical_resultid 0) it does not generate second result so the tasks is never completed.

I traced the problem a bit and it looks like transitioner counts any outcome "success" result as success, so it ignores VALIDATE_STATE_INVALID, as far as I can see it does not affect workunits with quorum > 1.

Changing the line 309 in transitioner.cpp (@rev 22647) from

nsuccess++;

to

if (res_item.res_validate_state != VALIDATE_STATE_INVALID) nsuccess++;

seems to fix the problem, at least for me, however I have no idea if it is a proper fix.

[davea]

(In [22839]) - transitioner: fix bug where retry jobs weren't getting sent

because invalid jobs were counted as successful. How could this bug possibly have survived this long? From TJM (thanks -- who are you?) Fixes #1029

[Pepo]

Replying to davea:

From TJM (thanks -- who are you?)

I believe /TJM is Slawomir Rzeznicki - the ​Enigma@Home admin. Occasionally also on boinc_dev + boinc_projects mailing lists.