| 1 | | sub-page |
| | 1 | = Reviewer Expectations = #ExpectationsofCodeReview-ReviewerExpectations |
| | 2 | * Have verified that Definition of Done has been completed |
| | 3 | * Visual inspection of code to see that it does what it needs to and doesn't do what is not reported |
| | 4 | * Confirmed that all comments and questions raised in discussion of the pull request have been resolved |
| | 5 | * If possible, a reviewer should build and test the code changes |
| | 6 | * Merging a pull request is a statement of "I believe this code is of good quality" |
| | 7 | * Check that consensus voting has resulted in approval of each issue resolved with the pull request (see governance document for details) |
| | 8 | * Check that consensus voting has resulted in approval of the pull request itself (see governance document for details) |
