Ticket #872: some.forum.test.tweaks.and.trivial.changes.in.your.accot.page.patch

inc/forum.inc

@@ -108 +108 @@
 // show a banner with search form on left and PM info on right
 //
 function show_forum_header($user) {
-    echo "<form action=\"forum_search_action.php\" method=\"POST\">
-    ";
-    start_table_noborder();
-    echo "<tr>
-    ";
-    
-    // Search
-    echo "
-        <td>
-        <input type=\"hidden\" name=\"search_max_time\" value=\"30\">
-        <input type=\"hidden\" name=\"search_forum\" value=\"-1\">
-        <input type=\"hidden\" name=\"search_sort\" value=\"5\">
-        <input type=\"text\" name=\"search_keywords\">
-        <input class=\"btn\" title=\"".tra("Search for words in forum messages")."\" type=\"submit\" value=\"".tra("Search forums")."\"><br>
-        <span class=\"smalltext\"><a href=\"forum_search.php\">".tra("Advanced search")."</a></span>
-        </td>
-    ";
-    
-    if ($user) {
-        echo "<td align=\"right\">\n";
-        echo "<p>".tra("Private messages").": ", pm_notification($user);
-        echo "</td>\n";
-    }
-    echo "</tr>
-    ";
-    end_table();
-    echo "</form>
-    ";
+
+        start_table_noborder(); 
+        // Search
+        ?>
+        <tr><td>
+        <form action="forum_search_action.php" method="POST">
+                <input type="hidden" name="search_max_time" value="30">
+                <input type="hidden" name="search_forum" value="-1">
+                <input type="hidden" name="search_sort" value="5">
+                <div class="bordered" id="searchbox">
+                        <input type="text" name="search_keywords">
+                        <input class="btn" title="<?php echo tra("Search for words in forum messages") ?>" type="submit" value="<?php echo tra("Search forums") ?>"><br />
+                        <span class="smalltext"><a href="forum_search.php"><?php echo tra("Advanced search") ?></a></span>
+                </div>
+        </form>
+        <?php
+
+        // Private Messages
+        if ($user) {
+                echo "<div class=\"bordered\" id=\"pmbox\">".tra("Private messages").": ", pm_notification($user);
+                echo "</div></td></tr>\n";
+        }
+        end_table();
+
 }
 
 // Output the forum/thread title.

inc/user.inc

@@ -194 +194 @@
         $email_text = "Verification pending";
     }
 
-    row1(tra("Account information"));
+    row1_top(tra("Account information"));
     row2(tra("Name"), $user->name);
     row2(tra("Email address"), $email_text);
     if (strlen($user->url)) {
@@ -231 +231 @@
 }
 
 function show_community_private($user) {
-    row1(tra("Community"));
+    row1_top(tra("Community"));
 
     if ($user->has_profile) {
         $x = "<a href=\"view_profile.php?userid=$user->id\">".tra("View")."</a> | <a href=\"delete_profile.php\">".tra("Delete")."</a>";

inc/util.inc

@@ -274 +274 @@
     echo "<tr><td class=\"$class\" colspan=\"$ncols\">$x</td></tr>\n";
 }
 
+function row1_top($x, $ncols=2, $class="heading") {
+    echo "<tr><td class=\"$class ontop\" colspan=\"$ncols\">$x</td></tr>\n";
+}
+
 function row2($x, $y, $show_error=false) {
     if ($x=="") $x="<br>";
     if ($y=="") $y="<br>";

project.sample/project.inc

@@ -42 +42 @@
 
 function project_footer($show_return, $show_date, $prefix) {
     // If you include any links, prepend URL with $prefix
-    echo "<br><hr noshade size=1><center>";
+    echo "<br><hr /><center>";
     if ($show_return) {
         echo "<a href=".$prefix."index.php>Home</a> | <a href=".$prefix."home.php>My Account</a> | <a href=".$prefix."forum_index.php>Message Boards</a><br>\n";
     }

user/main.css

@@ -24 +24 @@
 h3, h4 { font-weight: bold; }
 
 hr {
+        border-top-width: 2px;
+        border-top-style: solid;
         size: 0;
         margin: 8px 2px;
 }
@@ -38 +40 @@
         margin: 2px;
 }
 
-table.bordered {
+.bordered {
         border-width: 2px;
         border-style: solid;
         -moz-border-radius: 6px;
@@ -104 +106 @@
         vertical-align: middle;
 }
 
+.ontop {
+        -moz-border-radius: 6px 6px 0 0;
+        -khtml-border-radius-topleft: 6px;
+        -khtml-border-radius-topright: 6px;
+        -webkit-border-radius-topleft: 6px;
+        -webkit-border-radius-topright: 6px;
+        border-radius-topleft: 6px;
+        border-radius-topright: 6px;
+}
+
 .row0,
 .row1 ,
 .highlighted_row0,
@@ -131 +143 @@
         /* IE6 doesn't understand [type=XXXX] so we use class "button" */
 
 a.button {
-
         line-height: 2.4em;
         padding: 4px 8px;
         margin: 0 4px;
@@ -237 +248 @@
         height: 24px;
         margin-left: 4px;
         padding-left: 8px; 
-        -moz-border-radius: 0 10px;
+        -moz-border-radius: 0 0 10px 10px;
         -webkit-border-radius-bottomleft: 10px;
         -webkit-border-radius-bottomright: 10px;
         -khtml-border-radius-bottomleft: 10px;
@@ -348 +359 @@
         overflow: visible;
 }
 
+#pmbox  {
+        width: 240px;
+        height: 24px;
+        float: right;
+        text-align: center;
+        padding: 7px 0 0 0;
+}
+
+#searchbox {
+    width: 240px;
+    height: 45px;
+    float: left;
+    padding: 6px 0 2px 7px
+}
+
+#searchbox  input[type="text"]{
+        margin-left: 0;
+}
+
+#searchbox .btn {
+        padding: 3px 8px;
+}
+
 .forum_toplinks td {
         vertical-align: middle;
 }

user/white.css

@@ -12 +12 @@
 }
 
 hr {
-        border-top: 2px solid #e8e8e8;
+        border-top-color: #e8e8e8;
 }
 
-table.bordered {
+.bordered {
         border-color: #e8e8e8;
+        background-color: #fff;
 }
 
 th {
@@ -116 +117 @@
         background-color: #ddd;
 }
 
-td.postheader { 
+td.postheader ,
+td.postfooter { 
         background-color: #eee;
 }
 
 td.postbody { 
-        background: transparent url('img/75pct_white.png');
+        background-color: #fff;
 }
 
-td.postfooter {
-        background-color: #eee;
-}
-
 tr.postseperator {
         background-color: #c8c8c8;
         border-color: #aaa;