Ticket #489: forum_forum_php.patch

forum_forum.php

@@ -42 +42 @@
     $category = BoincCategory::lookup_id($forum->category); 
     if ($category->is_helpdesk){
         page_head(tra("Questions and Answers").' : '.$forum->title);
-        echo '<link href="forum_help_desk.php" rel="up" title="Forum Index">';
+        echo "<link href=\"forum_help_desk.php\" rel=\"up\" title=\"Forum Index\">";
     } else {
         page_head(tra("Message boards").' : '.$forum->title);
-        echo '<link href="forum_index.php" rel="up" title="Forum Index">';
+        echo "<link href=\"forum_index.php\" rel=\"up\" title=\"Forum Index\">";
     }
     show_forum_header($user);
     show_forum_title($category, $forum, NULL);
     break;
 case 1:
     $team = BoincTeam::lookup_id($forum->category); 
-    page_head("Team message board for <a href=team_display.php?teamid=$team->id>$team->name</a>");
+    page_head("Team message board for <a href=\"team_display.php?teamid=$team->id\">$team->name</a>");
     show_forum_header($user);
     break;
 }
 
-echo '
-    <table width="100%" cellspacing="0" cellpadding="0">
-    <tr valign="top">
-    <td colspan=2>
-';
+echo "
+    <table width=\"100%\" cellspacing=\"0\" cellpadding=\"0\">
+    <tr valign=\"top\">
+    <td colspan=\"2\">
+";
 
 show_button("forum_post.php?id=$id", "New thread", "Add a new thread to this forum");
 
@@ -73 +73 @@
 }
 
 echo " <br><br></td>";
-echo '<td valign=top align="right">';
-echo '    <form action="forum_forum.php" method="get">
-    <input type="hidden" name="id" value="'.$forum->id.'">';
+echo "<td valign=\"top\" align=\"right\">";
+echo "<form action=\"forum_forum.php\" method=\"get\">
+        <input type=\"hidden\" name=\"id\" value=\"'.$forum->id.'\">";
 echo select_from_array("sort", $forum_sort_styles, $sort_style);
-echo '<input type="submit" value="Sort"></form></td>';
+echo "<input type=\"submit\" value=\"Sort\"></form></td>";
 echo "</tr></table>";
 
 show_forum($forum, $start, $sort_style, $user);
@@ -93 +93 @@
     $gotoStr = "";
     $nav = show_page_nav($forum, $start);
     if ($nav) {
-        $gotoStr = "<div align=\"right\">$nav</div><br>";
+        $gotoStr = "<div align=\"right\">$nav</div><br/>";
     }
     echo $gotoStr; // Display the navbar
     start_forum_table(array("", tra("Threads"), tra("Posts"), tra("Author"), tra("Views"), "<nobr>".tra("Last post")."</nobr>"));
@@ -115 +115 @@
         
         if ($thread->status==1){
             // This is an answered helpdesk thread
-            echo '<tr class="row_hd'.$n.'">';
+            echo "<tr class=\"row_hd'.$n.'\">";
         } else {
             // Just a standard thread.
-            echo '<tr class="row'.$n.'">';    
+            echo "<tr class=\"row'.$n.'\">";    
         }
         
-        echo "<td width=\"1%\" align=\"right\"><nobr>";
+        echo "<td class=\"threadicon\"><nobr>";
         if ($user && ($thread->rating()>$user->prefs->high_rating_threshold)) {
             show_image(EMPHASIZE_IMAGE, "This message has a high average rating");
         }
@@ -166 +166 @@
             $title = substr($title,0,$titlelength)."...";
         }
         $title = cleanup_title($title);
-        echo '<td class="threadline"><a href="forum_thread.php?id='.$thread->id.'"><b>'.$title.'</b></a><br></td>';
+        echo "<td class=\"threadline\"><a href=\"forum_thread.php?id='.$thread->id.'\">'.$title.'</a><br/></td>";
         $n = ($n+1)%2;
 
-        echo '
+        echo "
             <td>'.($thread->replies+1).'</td>
-            <td align="left"><div class="authorcol">'.user_links($owner).'</div></td>
+            <td class=\"threadauthor\"><div class=\"authorcol\">'.user_links($owner).'</div></td>
             <td>'.$thread->views.'</td>
-            <td style="text-align:right">'.time_diff_str($thread->timestamp, time()).'</td>
+            <td class=\"lastpost\">'.time_diff_str($thread->timestamp, time()).'</td>
             </tr>
-        ';
+        ";
         flush();
     }
     end_table();
-    echo "<br>$gotoStr";    // show page links
+    echo "<br/>$gotoStr";    // show page links
 }
 
 ?>