Ticket #421: profile_patch.patch

profile.inc

@@ -41 +41 @@
 //
 function show_combo_box($name, $filename, $selection=null) {
     if (!file_exists($filename)) {
-        echo "ERROR: $filename does not exist!  Cannot create combo box.<br>";
+        echo "ERROR: $filename does not exist! Cannot create combo box.<br>";
         exit();
     }
     echo "<select name=\"$name\">\n";
@@ -114 +114 @@
     rowify("<br>");
     show_textarea("response1", stripslashes($profile->response1));
     rowify("<br>");
-    row1( show_profile_heading2());
-    rowify( show_profile_question2().html_info());
+    row1(show_profile_heading2());
+    rowify(show_profile_question2().html_info());
     rowify("<br>");
     show_textarea("response2", stripslashes($profile->response2));
     rowify("<br>");
@@ -124 +124 @@
 }
 
 function show_textarea($name, $text) {
-    rowify("<textarea name=\"$name\" cols=80 rows=20>" . $text . "</textarea>");
+    rowify("<textarea name=\"$name\" cols=\"80\" rows=\"20\">" . $text . "</textarea>");
 }
 
 // When passed profile->verification, this function is used to tell the
@@ -133 +133 @@
 function offensive_profile_warning($verify_flag) {
     if ($verify_flag == 0) {
         return "
-            <font size='+2' color='33cc33'>
+            <font size=\"+2\" color=\"33cc33\">
             Your profile will be made visible to other people<br>
             as soon as it has been approved by the project.<br>
             This may take up to a few days.<br>
@@ -141 +141 @@
         ";
     } else if ($verify_flag == -1) {
         return "
-            <font size='+2' color='ff3333'>
+            <font size=\"+2\" color=\"ff3333\">
             Your profile has been marked as unacceptable.<br>
             It is not visible to other people. Please change it.<br>
             </font>
@@ -160 +160 @@
 
     if ($profile->has_picture) {
         echo "
-<tr><td colspan=2>
-<table border=0 cellpadding=5
+<tr><td colspan=\"2\">
+<table border=\"0\" cellpadding=\"5\">
 <tr>
-<td valign=top><a href=\"" . IMAGE_URL . $profile->userid . '.jpg' . "\"><img src=\"" . IMAGE_URL . $profile->userid . '_sm.jpg' . "\"></a>
+<td valign=\"top\"><a href=\"" . IMAGE_URL . $profile->userid . '.jpg' . "\"><img src=\"" . IMAGE_URL . $profile->userid . '_sm.jpg' . "\"></a>
 </td>
-<td valign=top> $warning Your profile picture is shown at left.
+<td valign=\"top\"> $warning Your profile picture is shown at left.
 <p>
-To replace it,
-click the \"Browse\" button and select a JPEG or PNG file (50KB or less).
-<input name=picture type=file><br>
+To replace it, click the \"Browse\" button and select a JPEG or PNG file (50KB or less).
+<input name=\"picture\" type=\"file\"><br>
 <p>
 To remove it from your profile, check this box:
-<input type=checkbox name=delete_pic>
+<input type=\"checkbox\" name=\"delete_pic\">
 <p>
 </td></tr>";
         rowify("<br>");
@@ -184 +183 @@
 click the \"Browse\" button and select a JPEG or PNG file.
 Please select images of 50KB or less.
 <p>
-<input name=picture type=file>
+<input name=\"picture\" type=\"file\">
         ");
         rowify("<br>");
     }
@@ -207 +206 @@
 
 function show_submit() {
     row1("Submit profile");
-    rowify("<p><input type=submit value=OK name=submit>");
+    rowify("<p><input type=\"submit\" value=\"OK\" name=\"submit\">");
 }
 
 // If the user with id = $userid has uploaded a picture his/herself,
@@ -400 +399 @@
     echo "
 <h2>Congratulations!</h2><p>
 Your profile was successfully entered into our database.<br><br>
-<a href=view_profile.php?userid=$user->id>View your profile</a><br>
+<a href=\"view_profile.php?userid=$user->id\">View your profile</a><br>
 ";
 
     page_tail();
@@ -415 +414 @@
 //   $descriptor is an optional file descriptor to write the table to.
 
 function show_user_table($members, $offset, $numToDisplay, $cols) {
-    echo "<table class=bordered border=1 cellpadding=5>\n";
+    echo "<table class=\"bordered\" border=\"1\" cellpadding=\"5\">\n";
 
     $rows = ceil($numToDisplay / $cols);
     $count = $offset;
@@ -436 +435 @@
                     continue;
                 }
 
-                echo "<td class=bordered width=7% height=64><center>";
+                echo "<td class=bordered width=\"7%\" height=\"64\"><center>";
 
                 $show_picture = $profile->has_picture;
                 if (profile_screening() && $profile->verification != 1) {
@@ -448 +447 @@
                     echo "&nbsp;";
                 }
 
-                echo "</center></td><td class=bordered width=33% height=64>\n", get_profile_summary($profile), "</td>";
+                echo "</center></td><td class=\"bordered\" width=\"33%\" height=\"64\">\n", get_profile_summary($profile), "</td>";
                 $count++;
             } else {
-                echo "<td width=7% height=64></td><td width=33% height=64></td>";
+                echo "<td width=\"7%\" height=\"64\"></td><td width=\"33%\" height=\"64\"></td>";
             }
         }
         echo "</tr>\n";
@@ -515 +514 @@
     start_table();
 
     if ($can_edit) {
-        row1("<a href=create_profile.php>Edit your profile</a>");
+        row1("<a href=\"create_profile.php\">Edit your profile</a>");
     }
     
-
     // If doing screening, only show picture in certain situations
     //
     $show_picture = $profile->has_picture;
@@ -562 +560 @@
         row1("Your feedback on this profile");
         row2(
             "Recommend this profile for User of the Day:",
-            "I <a href=profile_rate.php?userid=$userid&vote=recommend>like</a> this profile"
+            "I <a href=\"profile_rate.php?userid=$userid&vote=recommend\">like</a> this profile"
         );
         row2(
             "Alert administrators to an offensive profile:",
-            "I <a href=profile_rate.php?userid=$userid&vote=reject>don't like</a> this profile"
+            "I <a href=\"profile_rate.php?userid=$userid&vote=reject\">don't like</a> this profile"
         );
     }
 
@@ -578 +576 @@
     }
     if (isset($caching) && $caching) end_cache(USER_PROFILE_TTL,$cache_args);
 }
-?>
+?>
+ No newline at end of file